Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting prefix path for rpc protocols #406

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Aug 27, 2021

Resolves: aws/aws-sdk-js-v3#1399

Description of changes:
Similar to #368, allow setting the path prefix for RPC protocols.

TODO: add protocol test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner August 27, 2021 06:49
Copy link
Contributor

@adamthom-amzn adamthom-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your TODO: a follow-up protocol test would be great.

@trivikr trivikr changed the title allow setting prefix path for rpc protocols Allow setting prefix path for rpc protocols Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@aws-sdk/client-sns]: custom endpoint.path is not taken into account when making requests
3 participants