-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use downlevel-dts to generate TS 3.4 compatible types #266
Conversation
aws-sdk-js-v3 aws/aws-sdk-js-v3#1943 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the AWS repo only? I feel like other SDK implementer should not use this.
If we put this code in smithy-typescript, it would a recommendation from AWS to support old versions of TypeScript type definitions. And I would like to have that explicit recommendation. Without this recommendation, the SDK implementers will not be aware that their TypeScript types may not work with old versions of TypeScript. The implementer is always free to remove postbuild script, downlevel-dts dependency and typesVersions key. |
OK I was assuming the downleveled It has some overhead regarding the download package size. But they don't goes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve again
Issue #, if available:
Fixes: aws/aws-sdk-js-v3#1919
Description of changes:
use downlevel-dts to generate TS 3.4 compatible types for clients in AWS SDK for JavaScript
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.