remove body for GET/HEAD request in http binding #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AllanZhengYP
force-pushed
the
no-body-get
branch
from
794f8aa to
8487f2f
Compare
fixes: aws/aws-sdk-js-v3#1633 This change doesn't affect RPC protocols because they use POST all the time
AllanZhengYP
force-pushed
the
no-body-get
branch
from
8487f2f to
a345fad
Compare
trivikr
approved these changes
Nov 19, 2020
|
Seems like Smithy does support GET/HEAD request with a body. But it will warn the users to make sure they know what they do: code. Since the problem this PR to solve only exists in browsers. We should allow these requests with a body on modelling level. But in browser, the GET/HEAD requests' body will be omitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: aws/aws-sdk-js-v3#1633
This change doesn't affect RPC protocols because they use
POST all the time
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.