Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enums): generate enum Record keys when target is enum #1037

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 13, 2023

due to the closure of enums in #1028,

Map deserializers for Maps where the key is an enum need an update to be compatible.

prop: Record<Enum | string, Value>

becomes

prop: Record<Enum, Value>

@kuhe kuhe requested review from a team as code owners October 13, 2023 16:28
@kuhe
Copy link
Contributor Author

kuhe commented Oct 13, 2023

linked: aws/aws-sdk-js-v3#5356

@kuhe kuhe merged commit 85c3faf into smithy-lang:main Oct 13, 2023
@kuhe kuhe deleted the feat/enums branch October 13, 2023 19:10
@kuhe kuhe mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants