Add: runtime plugin placeholder code to Smithy Orchestrator #2465
Conversation
update: separate client and operation interceptors
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
|
||
| pub fn read_before_execution( | ||
| pub fn operation_read_before_execution( |
There was a problem hiding this comment.
Nit: I think we should make a macro to generate all these functions since they're completely identical except for the function names...
| client_plugins: Vec<Box<dyn RuntimePlugin>>, | ||
| operation_plugins: Vec<Box<dyn RuntimePlugin>>, |
There was a problem hiding this comment.
Vec would be a good start. We may later want to change them to VecDeque if we need to prepend plugins.
| } | ||
| } | ||
|
|
||
| impl RuntimePlugin for GetObjectEndpointOrc { |
There was a problem hiding this comment.
Haven't fully decided yet but we may need to define a separate struct GetObjectEndpointPlugin and impl RuntimePlugin on that.
There was a problem hiding this comment.
I'd like to get this merged and then assign you to that task.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
deleted the
update/add-runtime-plugins-placeholder-api-to-orchestrator
branch
update: add placeholder impl of runtime plugins
update: separate client and operation interceptors
I thought I had already added this in the other PR but these changes must have become lost somehow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.