Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename signing_service to signing_name #2911

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Aug 9, 2023

Part of the SigV4a update. I split this out to making review simpler.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi added the breaking-change This will require a breaking change label Aug 9, 2023
@Velfi Velfi requested review from a team as code owners August 9, 2023 15:18
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two missed doc strings, lgtm

aws/rust-runtime/aws-sigv4/src/lib.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-sigv4/src/lib.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi force-pushed the zhessler-rename-signing-service-to-signing-name branch from c6b897c to 37e1141 Compare August 17, 2023 16:33
@Velfi Velfi added this pull request to the merge queue Aug 17, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into main with commit 200fb61 Aug 17, 2023
@Velfi Velfi deleted the zhessler-rename-signing-service-to-signing-name branch August 17, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants