Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ResolveAwsEndpoint and related interfaces. #2390

Closed
wants to merge 1 commit into from

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Feb 16, 2023

Motivation and Context

Description

Remove deprecated interfaces as part of Endpoints 2.0 Migration

Testing

  • tests pass
  • extensive CI entry

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners February 16, 2023 21:19
@rcoh rcoh added breaking-change This will require a breaking change needs-sdk-review labels Feb 16, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

2. Replace usages with a [service-specific resolver override](https://docs.rs/aws-sdk-s3/latest/aws_sdk_s3/config/struct.Builder.html#method.endpoint_resolver).

The following APIs have been removed:
1. [`SdkConfig::endpoint_resolver()`](https://docs.rs/aws-config/0.54.1/aws_config/struct.SdkConfig.html#method.endpoint_resolver): This getter referred a field that has been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/referred a field/referred to a field/ ?

@rcoh rcoh closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants