Fix @length-constrained collection shapes whose members are not constrained
#2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strained The generated code these should have emitted was fixed in #2085 (it's bug number 2), but code generation is still crashing because the call to calculate the inner constraint violation symbol is performed _before_ checking that the collection's member can reach a constrained shape. The test that #2085 added in `constraints.smithy`: ```smithy @Length(max: 69) list LengthList { member: ConB } ``` was not exercising what it should have, since `ConB`, is its name hints at, is a constrained structure shape.
david-perez
requested review from
jdisanti and
crisidev
and removed request for
jdisanti
jjant
approved these changes
Dec 14, 2022
…constrained-shapes-whose-members-are-not-constrained
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Dec 14, 2022
…members-are-not-constrained
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jjant
deleted the
davidpz/fix-length-constrained-shapes-whose-members-are-not-constrained
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code these should have emitted was fixed in #2085 (it's
bug number 2), but code generation is still crashing because the call to
calculate the inner constraint violation symbol is performed before
checking that the collection's member can reach a constrained shape.
The test that #2085 added in
constraints.smithy:was not exercising what it should have, since
ConB, is its name hintsat, is a constrained structure shape.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.