-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify XML APIs are returning XML with root elements that match the models #1668
Comments
This gets especially muddy since some of the S3 operations overlap. For example, making a call to |
Errors are also complicated: awslabs/aws-sdk-rust#873 |
For |
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> When a `@contextParam` is marked as required, we will enforce it on inputs. Since these fields may influence endpoint, omitting them can result in a different target being hit. - #1668 - aws-sdk-rust#873 ## Description <!--- Describe your changes in detail --> ## Testing - [x] S3 Integration test ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
I don't see value in keeping this issue open anymore. I think most of the XML root issues have been discovered and fixed at this point. |
@jdisanti did some extra investigative work while reviewing my PR Add "invalid xml body root" check exemption for S3's
GetObjectAttributes
and found several other API that may require the same customization:s3#GetBucketLocation
s3#ListObjects
s3#ListObjectVersions
ec2#GetConsoleOutput
Test these APIs to see if they return XML errors. If they do, apply the same customization from my PR.
Alternatively,
Implement John's suggestion to use
xmlName
instead ofallowInvalidXmlRoot
and update any buggy operations (don't forgets3#GetObjectAttributes
)The text was updated successfully, but these errors were encountered: