Refactor endpoints to be Smithy-native #1641
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-refactor-part-1
branch
from
8836d0b to
9a5fa97
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-refactor-part-1
branch
from
9a5fa97 to
543ecae
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-refactor-part-1
branch
from
543ecae to
76385ae
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| let aws_endpoint = self | ||
| .0 | ||
| .resolve_endpoint(params.region.as_ref().unwrap_or( | ||
| /*EndpointError::message("no region in params")*/ |
| // unwrap safety: we just put it in the bag, we can take it out again. | ||
| let endpoint = props | ||
| .get::<aws_smithy_http::endpoint::Result>() | ||
| .map(|res|res.as_ref().unwrap()).unwrap(); |
There was a problem hiding this comment.
Is leaving a comment like this preferable to using .expect()?
There was a problem hiding this comment.
I did a cleaner version of this where I just replace the error with a leftover error
rcoh
force-pushed
the
endpoints-refactor-part-1
branch
from
76385ae to
e0a4a7e
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| @@ -48,6 +92,28 @@ pub enum InvalidEndpoint { | |||
| EndpointMustHaveAuthority, | |||
| } | |||
|
|
|||
| pub fn apply_endpoint(uri: &mut Uri, endpoint: &Uri, prefix: Option<&EndpointPrefix>) { | |||
| if self.endpoint.url() == "" { | ||
| panic!("URL was unset"); | ||
| } |
There was a problem hiding this comment.
| if self.endpoint.url() == "" { | |
| panic!("URL was unset"); | |
| } | |
| assert!(self.endpoint.url() != "", "URL was unset"); |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…-rs into endpoints-refactor-part-1
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
Description
This makes a 99% backwards compatible refactoring to:
aws_smithy_types::Endpointtypeaws_smithy_http::endpoint::ResolveEndpointtrait (tbd: this may move into aws_smithy_types)ResolveEndpointinside of<service>::Configinternally instead ofResolveAwsEndpointResolveAwsEndpointagainstResolveEndpointvia a staticParamsstruct (in the future, this will be code generated per-service).make_operationto write the endpoint into the bag instead of writing the endpoint resolver into the bag & update the AWS middleware accordinglyTesting
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.