Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cors doco #1079

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Update cors doco #1079

merged 2 commits into from
Aug 27, 2019

Conversation

adanilev
Copy link
Contributor

Issue #, if available:
The documentation does not mention the AddDefaultAuthorizerToCorsPreflight property that was added in #828.

Description of changes:

  • Added the AddDefaultAuthorizerToCorsPreflight parameter to the Template Specification doc
  • Added an example app that uses the DefaultAuthorizer + CORS.

Description of how you validated changes:
Deployed the resources and called the API.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Aug 11, 2019

Codecov Report

Merging #1079 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1079   +/-   ##
========================================
  Coverage    94.81%   94.81%           
========================================
  Files           69       69           
  Lines         3276     3276           
  Branches       639      639           
========================================
  Hits          3106     3106           
  Misses          89       89           
  Partials        81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61e707...944d82a. Read the comment docs.

@praneetap praneetap self-requested a review August 16, 2019 17:32
@praneetap praneetap self-assigned this Aug 16, 2019
@praneetap
Copy link
Contributor

Thanks for adding the example and fixing the docs! Really appreciate the contribution 👍

@keetonian keetonian merged commit 491f1e4 into aws:develop Aug 27, 2019
@adanilev adanilev deleted the update-cors-doco branch August 28, 2019 04:01
@danludwig
Copy link

When will this go to master? I searched the docs @ https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md trying to find this and didn't realize I had to switch to the develop branch.

@keetonian
Copy link
Contributor

@danludwig Yes, this will be merged into master soon with our v1.15.0 release.

@praneetap praneetap mentioned this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants