-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cors doco #1079
Update cors doco #1079
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1079 +/- ##
========================================
Coverage 94.81% 94.81%
========================================
Files 69 69
Lines 3276 3276
Branches 639 639
========================================
Hits 3106 3106
Misses 89 89
Partials 81 81 Continue to review full report at Codecov.
|
bdc5862
to
944d82a
Compare
Thanks for adding the example and fixing the docs! Really appreciate the contribution 👍 |
When will this go to master? I searched the docs @ https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md trying to find this and didn't realize I had to switch to the develop branch. |
@danludwig Yes, this will be merged into master soon with our v1.15.0 release. |
Issue #, if available:
The documentation does not mention the
AddDefaultAuthorizerToCorsPreflight
property that was added in #828.Description of changes:
AddDefaultAuthorizerToCorsPreflight
parameter to the Template Specification docDescription of how you validated changes:
Deployed the resources and called the API.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.