feat: Add proposed API changes within types declarations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertNader
approved these changes
Jan 20, 2022
boweihan
approved these changes
Jan 20, 2022
| export type StyleSettings = { | ||
| name?: string; | ||
| detailedName?: string; | ||
| color?: string; // CSS color string, i.e. 'red' or '#ffffff' |
There was a problem hiding this comment.
In the future we may need to add some hierarchy to this type definition (i.e. `BaseStyleSettings & ScatterPlotStyleSettings" to support component-specific style properties (for example, scatterplots with a "hue" color). This looks great for now though!
There was a problem hiding this comment.
on as as needed basis that makes sense 👍
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
…dgetClick Events (#37) Deprecates the OnAnchorClick with a generic OnSelectionChanged and OnWidgetClick Event Also centralizes the selection event anytime the selectedSceneNodeRef changes. Rely on Entity group to set the selected node rather than the AnchorWidget which only cares about click Add a bug fix that allows the anchor click deselect to fire if it is not another anchor
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add in type declarations for a proposed API change.
This contains no implementation. This makes no actual changes to any runtime behavior. That comes as a follow up. This is just to ensure I have the correct API prior to implementation.
Legal
This project is available under the Apache 2.0 License.