Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove prettier commands that dont mesh with build system #29

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

diehbria
Copy link
Contributor

@diehbria diehbria commented Jan 5, 2022

Linting, build system improvements

Overview

  • Enforce linting on mono-repo level test, to ensure that the github test workflow fails when linting rules are not appplied
  • Fix linting commands at mono-repo level
  • Apply missing linting rules

Legal

This project is available under the Apache 2.0 License.

@diehbria diehbria force-pushed the lint-check branch 2 times, most recently from e9e04fd to 9917279 Compare January 5, 2022 21:35
@diehbria diehbria marked this pull request as draft January 5, 2022 21:46
@diehbria diehbria force-pushed the lint-check branch 2 times, most recently from 4290892 to f9c0bd7 Compare January 11, 2022 23:29
@diehbria diehbria marked this pull request as ready for review January 11, 2022 23:51
NorbertNader
NorbertNader previously approved these changes Jan 12, 2022
@diehbria diehbria merged commit 225afef into main Jan 18, 2022
@diehbria diehbria deleted the lint-check branch January 18, 2022 23:21
sheilaXu pushed a commit that referenced this pull request Sep 23, 2022
…!= 30", while there is no data coming into scene viewer, the code will return "true" because it'll evaluate "undefined != 30". (#29)

Co-authored-by: David Wu <[email protected]>
TheEvilDev pushed a commit that referenced this pull request Nov 2, 2022
This was referenced Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants