-
Notifications
You must be signed in to change notification settings - Fork 28
fix: allow revinclude to return more than 10 resources #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution is correct. I left a couple of comments to tidy up the implementation.
Also, consider renaming the PR. Something like "fix: allow revinclude to return more than 10 resources".
It's often better to think about the end result instead of the specific internals being changed when thinking of a PR name.
Codecov Report
@@ Coverage Diff @@
## mainline #164 +/- ##
============================================
+ Coverage 90.93% 90.94% +0.01%
============================================
Files 35 35
Lines 1147 1149 +2
Branches 258 258
============================================
+ Hits 1043 1045 +2
Misses 103 103
Partials 1 1
Continue to review full report at Codecov.
|
src/constants.ts
Outdated
@@ -26,3 +26,5 @@ export const NON_SEARCHABLE_PARAMETERS = [ | |||
export const MAX_ES_WINDOW_SIZE: number = 10000; | |||
|
|||
export const MAX_CHAINED_PARAMS_RESULT: number = 100; | |||
|
|||
export const MAX_NUM_ES_HITS: number = 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this const is specific to inclusion params. Maybe rename to MAX_INCLUSION_PARAM_RESULTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the name suggestion, I've updated it as such!
Issue #154 , if available:
Description of changes:
Added a size parameter to the multisearch used by the inclusion parameters (include and revinclude). Updated test snapshots to include the size parameter.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.