Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: Throw error if url and POSTed resourceType do not match #172

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

rsmayda
Copy link
Contributor

@rsmayda rsmayda commented Sep 8, 2022

Issue #, if available: awslabs/fhir-works-on-aws-deployment#682

Description of changes: validating that url resourceType and resource's resourceType is the same

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsmayda rsmayda added the bug Something isn't working label Sep 8, 2022
@rsmayda rsmayda requested a review from a team as a code owner September 8, 2022 20:30
@rsmayda rsmayda self-assigned this Sep 8, 2022
@github-actions github-actions bot added the size/s label Sep 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #172 (7e55e9a) into mainline (354a5b6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           mainline     #172      +/-   ##
============================================
- Coverage     75.92%   75.90%   -0.03%     
============================================
  Files            47       47              
  Lines          1383     1386       +3     
  Branches        292      293       +1     
============================================
+ Hits           1050     1052       +2     
- Misses          333      334       +1     
Impacted Files Coverage Δ
src/router/bundle/bundleHandler.ts 91.66% <100.00%> (ø)
src/router/handlers/resourceHandler.ts 100.00% <100.00%> (ø)
src/router/validation/validationUtilities.ts 100.00% <100.00%> (ø)
src/router/validation/jsonSchemaValidator.ts 96.29% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354a5b6...7e55e9a. Read the comment docs.

Copy link
Contributor

@ssvegaraju ssvegaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsmayda rsmayda merged commit b1bd6e4 into mainline Sep 8, 2022
@rsmayda rsmayda deleted the verifyResourceType branch September 8, 2022 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants