Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

perf: partial failures for restHook Lambda #579

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

carvantes
Copy link
Contributor

Various performance improvements from working on the load tests.

  • The biggest change is switching to partial batch responses for the restHook Lambda
    https://aws.amazon.com/about-aws/whats-new/2021/11/aws-lambda-partial-batch-response-sqs-event-source/
  • Enforced a timeout for http requests (otherwise some requests sometimes hung up and timed out the whole Lambda function)
  • Added concurrency control for http requests in rest-hook lambda. Mostly so that they get a "fair" timeout value (otherwise they may timeout before even starting for real since creating a bunch of promises in parallel queues all the http requests internally but they may sit in the queue waiting for resources)
  • tuned some numbers in serverless.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carvantes carvantes requested a review from a team as a code owner February 24, 2022 09:00
@carvantes carvantes merged commit 467c0d2 into feat-subscriptions Mar 3, 2022
@carvantes carvantes deleted the dev-rest-hook-perf branch March 3, 2022 17:05
carvantes added a commit that referenced this pull request Mar 3, 2022
enforce max timeout in rest-hook
subMatcher Lambda perf tuning
carvantes added a commit that referenced this pull request Mar 7, 2022
* feat: add GSI to Resource DDB Table (#533)

* feat: Add data validation for subscription (#543)

* fix: remove _subsciptionStatus from export result field (#555)

* feat: sns, sqs, dlq for Subscriptions  (#554)

* feat: Rest hook Lambda (#558)

* feat: subscriptionReaper (#557)

* feat: add subscriptionsMatcher Lambda (#559)

* test: Add Subscriptions test infrastructure/helper (#569)

* fix: update unit tests for subscription reaper (#567)

* test: add subscriptions env vars in gh actions (#572)

* fix: encrypt logs for new Lambda fns (#574)

* test: add Subscription reaper tests (#575)

* feat: emit end to end latency metric from rest-hook Lambda (#570)

* test: add tests for tenant isolation of subscriptions (#577)

* feat: add DLQ for matcher Lambda (#576)

* test: add end to end tests for subscriptions (#578)

* perf: partial failures for restHook Lambda (#579)

* docs: add Subscription docs (#582)

Co-authored-by: Sukeerth Vegaraju <[email protected]>
Co-authored-by: zheyanyu <[email protected]>
Co-authored-by: Yanyu Zheng <[email protected]>
Co-authored-by: brndhpkn <[email protected]>
carvantes added a commit that referenced this pull request Mar 7, 2022
* feat: add support for FHIR subscriptions

* perf: partial failures for restHook Lambda (#579)

* docs: add Subscription docs (#582)

Co-authored-by: Sukeerth Vegaraju <[email protected]>
Co-authored-by: zheyanyu <[email protected]>
Co-authored-by: Yanyu Zheng <[email protected]>
Co-authored-by: brndhpkn <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant