Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: add deletion policy to KMS keys #540

Merged
merged 3 commits into from
Mar 3, 2022
Merged

fix: add deletion policy to KMS keys #540

merged 3 commits into from
Mar 3, 2022

Conversation

carvantes
Copy link
Contributor

@carvantes carvantes commented Jan 7, 2022

Description of changes:

Add deletion policy policy to KMS keys. Without this the deletion policy on DDB and S3 buckets was not effective since the KMS key would be deleted an customers would lose access to S3/DDB data even if the Bucket/Table was retained

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carvantes carvantes changed the title fix: add retain policy to KMS keys fix: add deletion policy to KMS keys Jan 7, 2022
@carvantes carvantes changed the base branch from mainline to develop January 7, 2022 20:43
@carvantes carvantes changed the base branch from develop to mainline January 7, 2022 20:46
@carvantes carvantes changed the base branch from mainline to develop January 7, 2022 20:47
@carvantes carvantes changed the base branch from develop to mainline January 7, 2022 20:48
@carvantes carvantes changed the base branch from mainline to develop January 7, 2022 20:51
@carvantes carvantes marked this pull request as ready for review January 7, 2022 20:53
@carvantes carvantes requested a review from a team as a code owner January 7, 2022 20:53
@codecov-commenter
Copy link

Codecov Report

Merging #540 (f2993e7) into develop (2604e59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #540   +/-   ##
========================================
  Coverage    94.84%   94.84%           
========================================
  Files            1        1           
  Lines           97       97           
  Branches        14       14           
========================================
  Hits            92       92           
  Misses           5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2604e59...f2993e7. Read the comment docs.

@carvantes carvantes merged commit 9991809 into develop Mar 3, 2022
@carvantes carvantes deleted the dev-kms-retain branch March 3, 2022 03:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants