This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: Fix Implentation guide integration test #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyen102
requested review from
carvantes,
rsmayda,
Bingjiling and
ssvegaraju
ssvegaraju
approved these changes
Sep 30, 2021
ssvegaraju
approved these changes
Sep 30, 2021
carvantes
suggested changes
Sep 30, 2021
| `https://www.hl7.org/fhir/us/core/${usCoreVersion}/CapabilityStatement-us-core-server.json`, | ||
| { | ||
| httpsAgent: new https.Agent({ | ||
| rejectUnauthorized: false, |
There was a problem hiding this comment.
It's probably better to download the capability statement from https://www.hl7.org/fhir/us/core/STU3.1.1/CapabilityStatement-us-core-server.json and commit the file as part of the integ tests code. That gets rid of any other transient issue (i.e. www.hl7.org is down) and the json files are not that big.
Plus, disabling certificate validation is an odd choice that will be flagged by any security scan. (CodeQL already flagged it). We could dismiss it as "used in tests" but that's less than ideal
carvantes
approved these changes
Oct 1, 2021
carvantes
pushed a commit
that referenced
this pull request
Oct 1, 2021
* Update to use downloaded JSON Co-authored-by: Tim Nguyen <[email protected]>
carvantes
added a commit
that referenced
this pull request
Oct 1, 2021
Co-authored-by: Tim Nguyen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In the IG test we're making a request to https://www.hl7.org/fhir/us/core/STU3.1.1/CapabilityStatement-us-core-server.json. We're comparing our Cap Statement with the official FHIR Cap statement. Unfortunately the SSL cert at that domain has expired. The fix in this PR allows us to make a request to that URL even though the SSL cert on that domain has expired.
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.