Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: Create an SNS topic, policy, Ok & AlarmActions to cloudwatch alarms #447

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

Zambonilli
Copy link
Contributor

@Zambonilli Zambonilli commented Sep 17, 2021

Issue #, if available:
Issue #446

Description of changes:
Added a shell SNS Topic, Topic Policy and attached SNS topic as OkActions and AlarmActions to all Cloudwatch Alarms.

Checklist:

  • [x ] Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…kActions and AlarmActions to existing cloudwatch alarms
@rsmayda rsmayda changed the title feat: [Issue #446] Create an SNS topic, topic policy and add OkAction… feat: Create an SNS topic, topic policy and add OkAction Sep 21, 2021
@rsmayda rsmayda changed the title feat: Create an SNS topic, topic policy and add OkAction feat: Create an SNS topic, policy, Ok & AlarmActions to existing cloudwatch alarms Sep 21, 2021
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great minor suggestion

cloudformation/alarms.yaml Outdated Show resolved Hide resolved
cloudformation/alarms.yaml Outdated Show resolved Hide resolved
@rsmayda rsmayda changed the title feat: Create an SNS topic, policy, Ok & AlarmActions to existing cloudwatch alarms feat: Create an SNS topic, policy, Ok & AlarmActions to cloudwatch alarms Sep 21, 2021
…isplayName to allow for 0 interruption updates per code review comments.
cloudformation/alarms.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Approved on my end will get another engineer to review this as well

@rsmayda rsmayda merged commit 50871c5 into awslabs:develop Sep 22, 2021
@Zambonilli Zambonilli deleted the feature/cloudwatch_alarm_sns_pr branch September 22, 2021 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants