Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close temp resource properly #892

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I1ec3ada3639774cafd98ba8530ce9a45bbc8e5de
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #892 (6ffd173) into master (c23e291) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #892      +/-   ##
============================================
- Coverage     70.37%   70.36%   -0.01%     
  Complexity     5085     5085              
============================================
  Files           501      501              
  Lines         22419    22423       +4     
  Branches       2326     2327       +1     
============================================
+ Hits          15778    15779       +1     
- Misses         5399     5403       +4     
+ Partials       1242     1241       -1     
Impacted Files Coverage Δ Complexity Δ
...pi/src/main/java/ai/djl/ndarray/BaseNDManager.java 54.00% <60.00%> (-2.25%) 22.00 <0.00> (-1.00)
api/src/main/java/ai/djl/inference/Predictor.java 87.50% <0.00%> (-2.89%) 23.00% <0.00%> (-1.00%)
api/src/main/java/ai/djl/repository/Artifact.java 93.10% <0.00%> (+3.44%) 38.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23e291...6ffd173. Read the comment docs.

@frankfliu frankfliu merged commit ff762e8 into deepjavalibrary:master Apr 23, 2021
@frankfliu frankfliu deleted the nd branch April 23, 2021 17:33
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
* Add lmi-dist integration tests

* Review changes

* Review changes

* Review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants