add finding BlockFactory feature in model loading #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 1, 2021 15:50
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
============================================
+ Coverage 70.27% 70.37% +0.10%
- Complexity 4963 4991 +28
============================================
Files 486 486
Lines 21793 21873 +80
Branches 2263 2277 +14
============================================
+ Hits 15314 15394 +80
Misses 5279 5279
Partials 1200 1200
Continue to review full report at Codecov.
|
goswamig
reviewed
Apr 2, 2021
| // we only consider .class files and skip .java files | ||
| List<Path> jarFiles = | ||
| Files.list(path) | ||
| .filter(p -> p.toString().endsWith(".jar")) |
There was a problem hiding this comment.
it it possible we have some other type of file as well ?
There was a problem hiding this comment.
We only scan on the .class files. These mostly only live in Java jars.
Change-Id: I87e2c31443a7f2c21874b16991f91e539832a2b7
frankfliu
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support BlockFactory searching and loading in the current Model directory. This method should work on:
We will scan through this and figure out if there is a class implements BlockFactory.