Model Searching #799
Model Searching #799
Conversation
… and version for the model.
Change-Id: I50d2b0e56b2a9597bd96dd2f1c6b2921d542aeeb
| </div> | ||
| </TreeItem> | ||
| </TreeView> | ||
| <TreeItem nodeId="Models" label="Models"> |
There was a problem hiding this comment.
Rather than building a completely new UI, think about if it can be merged with an existing UI. Can you show models using the existing model list?
There was a problem hiding this comment.
This is the new look I came up with for the Model Navigation system. I think it looks a little cleaner than the previous. Let me know if there's any modification that you think would make it look better.
| defaultCollapseIcon={<ExpandMoreIcon />} | ||
| defaultExpandIcon={<ChevronRightIcon />} | ||
| > | ||
| {modelZooData.map((application) => ( | ||
| <TreeItem nodeId={application.key} label={application.title}> |
There was a problem hiding this comment.
Can you keep the application trees when displaying the models? When having no search filters, which is probably the most common way users are going to use this page, it helps a lot in organizing the full list of models.
There was a problem hiding this comment.
I have now made it to where if there is no search filters are being used it will display the model list with the application trees and if it is filtered it will begin to show each model. Hopefully that addresses this comment.
| <TreeItem nodeId={'Models'} label={'Models'}></TreeItem> | ||
| <div> | ||
| {modelList.map(application => ( | ||
| console.log(application), |
| @@ -86,25 +98,117 @@ export default function ModelNavigator(props) { | |||
| const modelZooData = useFetch(URL); | |||
|
|
|||
| const [model, setModel] = useState(null); | |||
| const [modelList, setModelList] = useState([]); | |||
There was a problem hiding this comment.
Change the modelLists default value from [] into modelZooData. That way, users start in the page having models to look at before being able to search to help find the model they want.
Currently, the convolution testing tests with a range of inputs across a number of variables. This increases the test duration a bit much for the standard unit test suite. Instead, I reduce down to only two tests for unit testing. During nightly, the full combination of ranges will be used. Change-Id: I3b9671e2c353315368d5dff07271607cc6917c4c
|
Please rebase and resolve conflicts |
… and version for the model.
…odelSearching # Conflicts: # central/src/main/webapp/components/ModelNavigator.jsx
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
============================================
- Coverage 70.32% 70.28% -0.04%
+ Complexity 4970 4967 -3
============================================
Files 486 486
Lines 21793 21793
Branches 2263 2263
============================================
- Hits 15325 15318 -7
- Misses 5273 5278 +5
- Partials 1195 1197 +2
Continue to review full report at Codecov.
|
Allowing users to search the ModelView Ui for a model via name, type, and version for the model.
Description
This PR creates a basic model view search experience for users to find a model quickly in comparison to looking through all of the models through the regular navigation system.
#637