Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plus-17): adds externalName to service props #424

Merged
merged 8 commits into from
Dec 31, 2020
Merged

fix(plus-17): adds externalName to service props #424

merged 8 commits into from
Dec 31, 2020

Conversation

pusherman
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

  • Adds externalName to service props
  • Validates externalName is set when using an EXTERNAL_NAME type
  • Adds externalIPs test to get back to 100% coverage in the service tests

@pusherman pusherman changed the title fix(plus-17) adds externalName to service props fix(plus-17): adds externalName to service props Nov 26, 2020
@iliapolo iliapolo self-assigned this Nov 27, 2020
@pusherman pusherman requested a review from eladb December 1, 2020 13:57
@iliapolo iliapolo assigned eladb and unassigned iliapolo Dec 6, 2020
eladb
eladb suggested changes Dec 7, 2020
View reviewed changes
packages/cdk8s-plus-17/src/service.ts Outdated Show resolved Hide resolved
packages/cdk8s-plus-17/test/service.test.ts Outdated Show resolved Hide resolved
@abierbaum abierbaum mentioned this pull request Dec 16, 2020
Closed
@pusherman pusherman requested a review from eladb December 16, 2020 22:03
@abierbaum
Copy link
Contributor

@eladb @pusherman Anything still pending on this PR? I would love to start using it in production instead of my other hack.

eladb
eladb approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry slipped my radar. Thanks for pinging

@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2020

Your pull request will be updated and merged automatically (do not update manually).

@mergify mergify bot merged commit b4b7c55 into cdk8s-team:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pusherman @abierbaum @eladb @iliapolo