Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdk8s-cli] emit a single module per k8s API group as default for import from crds.dev #401

Closed
prasek opened this issue Nov 19, 2020 · 1 comment · Fixed by #402
Closed

[cdk8s-cli] emit a single module per k8s API group as default for import from crds.dev #401

prasek opened this issue Nov 19, 2020 · 1 comment · Fixed by #402
Assignees
@iliapolo
Labels
effort/medium 1 week tops feature-request New/Enhanced functionality wanted

Comments

@prasek
Copy link
Contributor

prasek commented Nov 19, 2020

Follow on to #377

Would like to generate a single module per k8s API group with all CRDs for that API group, so you could:

import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';

and have this be the default for importing from https://doc.crds.dev using:

cdk8s import github:account/repo[@VERSION]
@prasek prasek added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Nov 19, 2020
@prasek prasek mentioned this issue Nov 19, 2020
Merged
@iliapolo iliapolo added effort/medium 1 week tops p2 and removed needs-triage Priority and effort undetermined yet labels Nov 23, 2020
prasek added a commit to prasek/cdk8s that referenced this issue Nov 24, 2020
@prasek
feat(cli): emit single module per API group as default for crds.dev
f067e1c 
Emit a single module per API group for crds.dev import by default, so after you:
`cdk8s import github:account/repo[@Version]`

you can use a single line import statement for multiple API types:
```
import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';
```

Resolves cdk8s-team#401

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Signed-off-by: Phil Prasek <[email protected]>
prasek added a commit to prasek/cdk8s that referenced this issue Nov 26, 2020
@prasek
feat(cli): emit single module per API group as default for crds.dev
df37a61 
Emit a single module per API group for crds.dev import by default, so after you:
`cdk8s import github:account/repo[@Version]`

you can use a single line import statement for multiple API types:
```
import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';
```

Resolves cdk8s-team#401

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Signed-off-by: Phil Prasek <[email protected]>
prasek added a commit to prasek/cdk8s that referenced this issue Dec 2, 2020
@prasek
feat(cli): import emits single module per API group
5eaa652 
Emit a single module per API group for all crd immports, so after you:
`cdk8s import github:account/repo[@Version]`

you can use a single line import statement for multiple API types:
```
import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';
```

Resolves cdk8s-team#401

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Signed-off-by: Phil Prasek <[email protected]>
@mergify mergify bot closed this as completed in #402 Dec 3, 2020
mergify bot pushed a commit that referenced this issue Dec 3, 2020
@prasek
feat(cli): import a single module per api group (#402)
ac295fe 
Follow-on to #378 

Emit a single module per API group for all imports:
```sh
cdk8s import github:account/repo[@Version]
```
you can use a single line import statement for multiple API types:
```ts
import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';
```

Here's some sample output:
https://github.com/prasek/crossplane-cdk/tree/cross-pkg/test/imports/provider-aws

Resolves #401

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

campionfellin pushed a commit to campionfellin/cdk8s that referenced this issue Dec 11, 2020
@prasek @campionfellin
feat(cli): import a single module per api group (cdk8s-team#402)
2059e7a 
Follow-on to cdk8s-team#378 

Emit a single module per API group for all imports:
```sh
cdk8s import github:account/repo[@Version]
```
you can use a single line import statement for multiple API types:
```ts
import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io';
```

Here's some sample output:
https://github.com/prasek/crossplane-cdk/tree/cross-pkg/test/imports/provider-aws

Resolves cdk8s-team#401

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iliapolo iliapolo

Labels
effort/medium 1 week tops feature-request New/Enhanced functionality wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): import a single module per api group prasek/cdk8s
3 participants
@prasek @iliapolo @SomayaB