Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contributor instructions about using jsii docker image #397

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

abierbaum
Copy link
Contributor

I have found this helpful to run the integration tests on Linux.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

eladb
eladb previously approved these changes Nov 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2020

Your pull request will be updated and merged automatically (do not update manually).

@mergify mergify bot dismissed eladb’s stale review November 19, 2020 14:00

Pull request has been modified.

@abierbaum
Copy link
Contributor Author

@eladb Note sure why, but this PR seems to failing on a check. Any recommendation on what I am missing?

@eladb eladb merged commit bb0a5cc into cdk8s-team:master Nov 19, 2020
@abierbaum abierbaum deleted the jsii_docker_instructions branch December 31, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants