feat(cli): import from crds.dev #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasek
changed the title
cdk8s import crossplane/[email protected]cdk8s import crossplane/[email protected]
prasek
force-pushed
the
import-crds-dev
branch
4 times, most recently
from
21565e6 to
a5346fc
Compare
eladb
suggested changes
Nov 16, 2020
eladb
changed the title
cdk8s import crossplane/[email protected]
|
@prasek any updates? Also, make sure to re-request a review when ready for another round. |
prasek
force-pushed
the
import-crds-dev
branch
3 times, most recently
from
418fa05 to
6ce96e5
Compare
prasek
force-pushed
the
import-crds-dev
branch
from
6ce96e5 to
b520124
Compare
prasek
force-pushed
the
import-crds-dev
branch
from
b520124 to
b95677e
Compare
prasek
force-pushed
the
import-crds-dev
branch
from
b95677e to
5772a9a
Compare
|
@eladb should be good to go, thx. |
eladb
suggested changes
Nov 18, 2020
prasek
force-pushed
the
import-crds-dev
branch
from
5772a9a to
b014249
Compare
prasek
force-pushed
the
import-crds-dev
branch
from
b014249 to
8292a0e
Compare
Introduce crds.dev import shortcut: `cdk8s import github:account/repo[@Version]` Example: `cdk8s import github:crossplane/[email protected]` Resolves cdk8s-team#377 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Signed-off-by: Phil Prasek <[email protected]>
prasek
force-pushed
the
import-crds-dev
branch
from
8292a0e to
a107a9f
Compare
|
@eladb test coverage is 100% should be good to go, thx. |
eladb
approved these changes
Nov 19, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
This was referenced Nov 19, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
Follow-on to #378 Emit a single module per API group for all imports: ```sh cdk8s import github:account/repo[@Version] ``` you can use a single line import statement for multiple API types: ```ts import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io'; ``` Here's some sample output: https://github.com/prasek/crossplane-cdk/tree/cross-pkg/test/imports/provider-aws Resolves #401 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
campionfellin
pushed a commit
to campionfellin/cdk8s
that referenced
this pull request
Dec 11, 2020
Follow-on to cdk8s-team#378 Emit a single module per API group for all imports: ```sh cdk8s import github:account/repo[@Version] ``` you can use a single line import statement for multiple API types: ```ts import { CompositeResourceDefinition, Composition } from './imports/apiextensions.crossplane.io'; ``` Here's some sample output: https://github.com/prasek/crossplane-cdk/tree/cross-pkg/test/imports/provider-aws Resolves cdk8s-team#401 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce crds.dev import shortcut:
cdk8s import github:account/repo[@VERSION]Example:
cdk8s import github:crossplane/[email protected]Resolves #377
In a future PR would like to generate a single module per k8s API group with all CRDs for that API group, so you could:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license