feat(cli): stdout option for cdk8s synth #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdk8s-team#92 Signed-off-by: campionfellin <[email protected]>
Signed-off-by: campionfellin <[email protected]>
eladb
reviewed
Nov 12, 2020
eladb
suggested changes
Nov 12, 2020
Co-authored-by: Elad Ben-Israel <[email protected]>
campionfellin
commented
Nov 17, 2020
Signed-off-by: campionfellin <[email protected]>
campionfellin
commented
Nov 17, 2020
eladb
suggested changes
Nov 17, 2020
campionfellin
commented
Nov 17, 2020
eladb
suggested changes
Nov 18, 2020
packages/cdk8s-cli/src/util.ts
Outdated
| @@ -32,6 +32,35 @@ export async function mkdtemp(closure: (dir: string) => Promise<void>) { | |||
| } | |||
| } | |||
|
|
|||
| export async function callLibrary(command: string, outdir: string) { | |||
There was a problem hiding this comment.
Rename to synthApp and combine with validateSynthesis
There was a problem hiding this comment.
Can you please also write a small unit test for this?
There was a problem hiding this comment.
I wrote a couple of example tests, if you think that's the kind of style we want there I can fill them out a bit more!
Signed-off-by: campionfellin <[email protected]>
Signed-off-by: campionfellin <[email protected]>
|
Your pull request will be updated and merged automatically (do not update manually). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
Signed-off-by: campionfellin [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license