Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): updates to hello-world example and directory reorganization #33

Merged
merged 9 commits into from
Mar 6, 2020

Conversation

campionfellin
Copy link
Contributor

We want more examples (as per #22) but we should improve the current examples first so they work out of the box (git clone straight to example).

🎉First PR 🎉

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@campionfellin
Copy link
Contributor Author

Looks like the yarn build from Lerna is failing because the build script in the example doesn't do the generate first.

Do we want:

  1. Lerna to ignore the /examples
  2. Examples to contain the cdk8s generate in build script?

I'd lean more towards 1, as I don't think cdk8s generate is needed for every build.

@eladb
Copy link
Contributor

eladb commented Mar 4, 2020

@campionfellin I think we should reorganize examples such that each example is a separate project (like yours) and change lerna and yarn from looking under examples to examples/* (should be both in package.json and lerna.json).

@campionfellin campionfellin force-pushed the examples branch 2 times, most recently from b0a431a to b9468de Compare March 5, 2020 15:46
@campionfellin campionfellin requested a review from eladb March 6, 2020 15:25
@eladb eladb changed the title Updates Hello-World Example feat(examples): updates to hello-world example and directory reorganization Mar 6, 2020
@eladb eladb merged commit 1c8f694 into cdk8s-team:master Mar 6, 2020
@campionfellin campionfellin deleted the examples branch March 7, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants