aws-smithy-client 0.54.2 breaks athena client

[erwanncloarec]

Description of the bug

After running cargo update on one of my project, I had errors coming from aws-smithy-client at runtime.
It has been updated to 0.54.2, and by forcing it back to =0.54.1 everything went well.

How to reproduce

Cargo.toml

[dependencies]
tokio = { version = "*", features = ["full"]}
aws-smithy-client = { version = "=0.54.2" }
aws-sdk-athena = { version = "=0.24.0" }
aws-config = { version =  "0.54.1", default-features = false }

main.rs

use aws_config::retry::RetryConfig;

#[tokio::main]
async fn main() {
    let shared_config = aws_config::load_from_env().await;
    let config = aws_sdk_athena::config::Builder::from(&shared_config)
        .retry_config(RetryConfig::standard())
        .build();
    let client = aws_sdk_athena::Client::from_conf(config);
    let query_execution_id = match client
        .start_query_execution()
        .work_group("primary")
        .query_string("select count(*) from mytable")
        .send()
        .await
    {
        Ok(res) => String::from(res.query_execution_id().unwrap()),
        Err(e) => panic!("{e}"),
    };
    println!("Query running {query_execution_id}");
}

This codes panics with :

thread 'main' panicked at 'failed to construct request', src/main.rs:18:19

But with:

aws-smithy-client = { version = "=0.54.1" }

It works:

Query running ce628d28-b971-4823-87f8-1016ec1d5ed2

Note: I'm not sure if it's relevant but in my local environment, I use AWS_PROFILE environment variable.

[jdisanti]

I was able to reproduce, but only after setting default-features = true on aws-config. You can add more context to that panic by doing the following:

use aws_sdk_athena::types::DisplayErrorContext;

// --snip --

        Err(e) => panic!("{}", DisplayErrorContext(e)),

That reveals the full error to be:

thread 'main' panicked at 'failed to construct request: could not construct endpoint parameters: a required field was missing: `region` (ConstructionFailure(ConstructionFailure { source: ResolveEndpointError { message: "could not construct endpoint parameters", source: Some(InvalidParams { field: "region" }) } }))', src/main.rs:19:19

Setting the AWS_REGION env var after that led to a different error that indicates an output location is required on the Athena request.

[erwanncloarec]

With the DisplayErrorContext, I ended up with "invalid URL, scheme is not http: invalid URL, scheme is not http".
When trying with rustls feature of aws-config it works fine, but with the native-tls it breaks. I saw that rustls is in the default features, so that's why it's working when using default-features = true.

[Velfi]

It turns out this issue was caused by a tiny mistake in recent PR. I have a fix in PR right now.

[Velfi]

The PR is merged and the fix is pending release.

[LukeMathWalker]

The fix has been released to crates.io - https://github.com/awslabs/smithy-rs/releases/tag/release-2023-02-14

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.