Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IMDSv1 for authentication #520

Closed
1 of 2 tasks
jszwedko opened this issue Apr 22, 2022 · 2 comments
Closed
1 of 2 tasks

Support IMDSv1 for authentication #520

jszwedko opened this issue Apr 22, 2022 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@jszwedko
Copy link
Contributor

Describe the feature

When switching from rusoto to aws-sdk-rust for https://github.com/vectordotdev/vector, we realized there wasn't support for IMSDv1 for authentication.

I know IMDSv2 is preferred nowadays but we believe we are likely to still have users running without it.

Would you be open to a PR adding support for IMDSv1?

Use Case

When IMDSv2 is unavailable, we'd like to fallback to trying IMDSv1.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@jszwedko jszwedko added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2022
@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Apr 25, 2022
@rcoh
Copy link
Contributor

rcoh commented Apr 26, 2022

The plan is to fully remove IMDSv1 support so we actually can't provide support for it in the SDK at this time.

If you have customers currently on hosts that do not support IMDSv2 I'd be interested in hearing more about the cause.

In any case, it is possible to extend credential providers to add support–you can do it in an external crate by wrapping the default chain and adding a fallback to your own ImdsV1 implementation.

@rcoh rcoh closed this as completed Apr 26, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants