fix(data-classes): docstring typos and clean up #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Use correct wording: `built-in`, `its`, `sign in`, `all the` and `case-sensitive` - Modern use of `super()` - Use `startswith` instead of `resource[:1] == "/"`
pull-request-size
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## develop #937 +/- ##
===========================================
- Coverage 99.96% 99.96% -0.01%
===========================================
Files 119 119
Lines 5322 5320 -2
Branches 614 613 -1
===========================================
- Hits 5320 5318 -2
Partials 2 2
Continue to review full report at Codecov.
|
|
@heitorlessa - some small housekeeping fixes. |
heitorlessa
suggested changes
Jan 11, 2022
aws_lambda_powertools/utilities/data_classes/api_gateway_authorizer_event.py
Outdated
Show resolved
Hide resolved
michaelbrewer
changed the title
heitorlessa
suggested changes
Jan 11, 2022
heitorlessa
reviewed
Jan 12, 2022
| @@ -28,11 +28,12 @@ def __init__( | |||
| self.api_id = api_id | |||
| self.stage = stage | |||
| self.http_method = http_method | |||
| self.resource = resource | |||
| # Remove matching "/" from `resource`. | |||
heitorlessa
approved these changes
Jan 12, 2022
heitorlessa
changed the title
|
Updated description on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
It's been a while since i scanned through the data classes for typos and improvements.
Description of changes:
Changes:
built-in,its,sign in,all theandcase-sensitivesuper()resource.lstrip("/")instead ofresource[:1] == "/"for readability to remove leading "/" that isn't allowed when constructing an authorizer response objectChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.