-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: customize contributing guide #77
docs: customize contributing guide #77
Conversation
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 516 516
Branches 49 49
=========================================
Hits 516 516 Continue to review full report at Codecov.
|
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
I didn't add a CodeTour as initially planed since there will be deletion, and CodeTour needs to be pinned to a tag - I'll wait until GA. |
I removed because I created a bug report template issue that asks for more
details - I’m fine putting this back to Contributing if you think is
helpful.
Re: PR, good point - I’ll pick one and update it
…On Sat, 13 Jun 2020 at 09:48, Nicolas Moutschen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#77 (comment)>
:
>
When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already
-reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
-
-* A reproducible test case or series of steps
Why remove this? I think this is rather helpful for us to reproduce the
issue.
------------------------------
In CONTRIBUTING.md
<#77 (comment)>
:
> 4. Commit to your fork using clear commit messages.
-5. Send us a pull request, answering any default questions in the pull request interface.
+5. Send us a pull request with a [conventional semantic title](https://github.com/awslabs/aws-lambda-powertools-python/pulls?q=is%3Apr+is%3Aclosed), and answering any default questions in the pull request interface.
Should we have a link to what is a conventional semantic title? This links
to closed PRs, which is descriptive rather than prescriptive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#77 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGFUYXDFOQQFSSOEGDRWM4OPANCNFSM4N4EY6QA>
.
|
I checked the bug report template and looks good to me there, I'm fine keeping the steps out of CONTRIBUTING.md. |
Signed-off-by: heitorlessa <[email protected]>
* develop: docs: customize contributing guide (#77) chore: move blockquotes as hidden comments
* docs: clean up contributing guide Signed-off-by: heitorlessa <[email protected]> * docs: add local documentation section Signed-off-by: heitorlessa <[email protected]> * feat: experiment with Gitpod pre-build env Signed-off-by: heitorlessa <[email protected]> * fix: unnecessary exc_info in example exception * docs: add conventions we use across the project Signed-off-by: heitorlessa <[email protected]> * chore: remove gitpod due to poetry issue * chore: develop branch in bold Signed-off-by: heitorlessa <[email protected]> * chore: add link to RFC issue, fix typo Signed-off-by: heitorlessa <[email protected]> * chore: address Nicolas feedback on PR link Signed-off-by: heitorlessa <[email protected]>
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits) feat: add metrics metadata (#81) chore: cleanup tests (#79) chore: remove deprecated code before GA (#78) docs: customize contributing guide (#77) chore: move blockquotes as hidden comments chore: update CHANGELOG chore: bump version to 0.11.0 (#76) chore: version bump 0.10.1 fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74) docs: fix contrast on highlighted code text (#73) feat: improve error handling for log_metrics decorator (#71) chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs feat: add high level imports (#70) fix: correct env var name for publish to pypi test (#69) chore: version bump (#68) feat: add capture_cold_start_metric for log_metrics (#67) chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66) feat: automate publishing to pypi (#58) feat: add pre-commit hooks (#64) ...
Issue #, if available: #33
Description of changes:
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.