Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: customize contributing guide #77

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 12, 2020

Issue #, if available: #33

Description of changes:

One or two sentences as a summary of what's being changed

Breaking change checklist

Ignore if it's not a breaking change

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #77 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          516       516           
  Branches        49        49           
=========================================
  Hits           516       516           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9c3e6...4132ccd. Read the comment docs.

@heitorlessa heitorlessa changed the title docs: customize contributing guide [WIP] docs: customize contributing guide Jun 12, 2020
@heitorlessa heitorlessa changed the title [WIP] docs: customize contributing guide docs: customize contributing guide Jun 12, 2020
@heitorlessa heitorlessa requested review from to-mc and nmoutschen June 12, 2020 16:52
@heitorlessa
Copy link
Contributor Author

I didn't add a CodeTour as initially planed since there will be deletion, and CodeTour needs to be pinned to a tag - I'll wait until GA.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@heitorlessa
Copy link
Contributor Author

heitorlessa commented Jun 13, 2020 via email

@nmoutschen
Copy link
Contributor

I removed because I created a bug report template issue that asks for more details - I’m fine putting this back to Contributing if you think is helpful.

I checked the bug report template and looks good to me there, I'm fine keeping the steps out of CONTRIBUTING.md.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Jun 13, 2020
@heitorlessa heitorlessa removed the request for review from to-mc June 14, 2020 12:21
@heitorlessa heitorlessa merged commit 57d2905 into aws-powertools:develop Jun 14, 2020
@heitorlessa heitorlessa deleted the docs/contributing-guide branch June 14, 2020 12:21
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 14, 2020
* develop:
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
* docs: clean up contributing guide

Signed-off-by: heitorlessa <[email protected]>

* docs: add local documentation section

Signed-off-by: heitorlessa <[email protected]>

* feat: experiment with Gitpod pre-build env

Signed-off-by: heitorlessa <[email protected]>

* fix: unnecessary exc_info in example exception

* docs: add conventions we use across the project

Signed-off-by: heitorlessa <[email protected]>

* chore: remove gitpod due to poetry issue

* chore: develop branch in bold

Signed-off-by: heitorlessa <[email protected]>

* chore: add link to RFC issue, fix typo

Signed-off-by: heitorlessa <[email protected]>

* chore: address Nicolas feedback on PR link

Signed-off-by: heitorlessa <[email protected]>
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (104 commits)
  feat: add metrics metadata (#81)
  chore: cleanup tests (#79)
  chore: remove deprecated code before GA (#78)
  docs: customize contributing guide (#77)
  chore: move blockquotes as hidden comments
  chore: update CHANGELOG
  chore: bump version to 0.11.0 (#76)
  chore: version bump 0.10.1
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  fix: default dimension creation now happens when metrics are serialized instead of on metrics constructor (#74)
  docs: fix contrast on highlighted code text (#73)
  feat: improve error handling for log_metrics decorator (#71)
  chore(deps): bump graphql-playground-html from 1.6.19 to 1.6.25 in /docs
  feat: add high level imports (#70)
  fix: correct env var name for publish to pypi test (#69)
  chore: version bump (#68)
  feat: add capture_cold_start_metric for log_metrics (#67)
  chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#66)
  feat: automate publishing to pypi (#58)
  feat: add pre-commit hooks (#64)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants