Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): add amplify-cli instructions for public layer #754

Conversation

AlessandroVol23
Copy link
Contributor

@AlessandroVol23 AlessandroVol23 commented Oct 8, 2021

Description of changes:

After discussing with Alex and Heitor on this tweet and in DMs I've added a section on how to add aws-lambda-powertools-python in an existing Amplify project.

Just documentation changes

Checklist


View rendered docs/index.md

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 8, 2021
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 8, 2021

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@AlessandroVol23 AlessandroVol23 changed the title docs/Section on adding public arn to amplify docs: Section on adding public arn to amplify Oct 8, 2021
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth adding a link to find the latest Lambda Layer since that will change over time?

@heitorlessa
Copy link
Contributor

Perhaps worth adding a link to find the latest Lambda Layer since that will change over time?

Nvm I'm drunk. I immediately thought this was for the Amplify CLI docs :D

@heitorlessa heitorlessa changed the title docs: Section on adding public arn to amplify docs: add amplify-cli instructions for public layer Oct 8, 2021
@heitorlessa heitorlessa merged commit a3b7b14 into aws-powertools:develop Oct 8, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 8, 2021

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@heitorlessa heitorlessa added the hacktoberfest-accepted accepted hacktoberfest contributions label Oct 9, 2021
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Oct 12, 2021
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  chore(deps-dev): bump mkdocs-material from 7.3.2 to 7.3.3 (aws-powertools#758)
  chore(deps-dev): bump flake8-comprehensions from 3.6.1 to 3.7.0 (aws-powertools#759)
  chore(deps): bump boto3 from 1.18.58 to 1.18.59 (aws-powertools#760)
  chore(deps-dev): bump coverage from 6.0 to 6.0.1 (aws-powertools#751)
  chore(deps): bump boto3 from 1.18.56 to 1.18.58 (aws-powertools#755)
  docs: add amplify-cli instructions for public layer (aws-powertools#754)

Signed-off-by: heitorlessa <[email protected]>
@heitorlessa heitorlessa changed the title docs: add amplify-cli instructions for public layer docs(install): add amplify-cli instructions for public layer Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted accepted hacktoberfest contributions size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants