-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-classes): data_as_bytes prop KinesisStreamRecordPayload #628
feat(data-classes): data_as_bytes prop KinesisStreamRecordPayload #628
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
Thank you so much @hjurong !!! Merging this now and making part of today's release |
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 114 114
Lines 4597 4599 +2
Branches 254 254
========================================
+ Hits 4595 4597 +2
Partials 2 2
Continue to review full report at Codecov.
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
**Issue #617
Description of changes:
adding
data_as_bytes
helper toKinesisStreamRecordPayload
as described in linked issueChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.