Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-classes): data_as_bytes prop KinesisStreamRecordPayload #628

Merged
merged 1 commit into from
Aug 21, 2021
Merged

feat(data-classes): data_as_bytes prop KinesisStreamRecordPayload #628

merged 1 commit into from
Aug 21, 2021

Conversation

hjurong
Copy link

@hjurong hjurong commented Aug 21, 2021

**Issue #617

Description of changes:

adding data_as_bytes helper to KinesisStreamRecordPayload as described in linked issue

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2021

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2021
@hjurong hjurong changed the title [#617] add data_as_bytes method to KinesisStreamRecordPayload feat: add data_as_bytes method to KinesisStreamRecordPayload Aug 21, 2021
Copy link
Contributor

@michaelbrewer michaelbrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@heitorlessa heitorlessa added the feature New feature or functionality label Aug 21, 2021
@heitorlessa heitorlessa added this to the 1.20.0 milestone Aug 21, 2021
@heitorlessa
Copy link
Contributor

Thank you so much @hjurong !!! Merging this now and making part of today's release

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #628 (525170f) into develop (b2773d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #628   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          114      114           
  Lines         4597     4599    +2     
  Branches       254      254           
========================================
+ Hits          4595     4597    +2     
  Partials         2        2           
Impacted Files Coverage Δ
...ols/utilities/data_classes/kinesis_stream_event.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2773d5...525170f. Read the comment docs.

@heitorlessa heitorlessa self-assigned this Aug 21, 2021
@heitorlessa heitorlessa changed the title feat: add data_as_bytes method to KinesisStreamRecordPayload feat(data-classes): data_as_bytes prop KinesisStreamRecordPayload Aug 21, 2021
@heitorlessa heitorlessa merged commit 16563bb into aws-powertools:develop Aug 21, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2021

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants