-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parameters): auto-transforming values based on suffix #573
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report
@@ Coverage Diff @@
## develop #573 +/- ##
========================================
Coverage 99.86% 99.86%
========================================
Files 113 113
Lines 4485 4485
Branches 243 243
========================================
Hits 4479 4479
Misses 3 3
Partials 3 3 Continue to review full report at Codecov.
|
docs/utilities/parameters.md
Outdated
"b.binary": [some value] | ||
} | ||
``` | ||
```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some formatting issue
Fixed both formatting issues, thanks for the review |
@heitorlessa - don't forget to have a look at this one :) |
yep I have not. I need to revisit the wording on that sub-section. I think we can improve there but unsure what to suggest now. Once I finish the Feature Flags PR (refactoring+docs), I'll get back to this. This + another PR to be created to make Tracer disabled by default in non-Lambda environments, before I cut the 1.19.0 release |
Thanks a lot everyone - made minor changes to make it easier to find in the docs. Merging! |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue #, if available:
#562
Description of changes:
Added subsection under "Utilities > Parameters > Advanced > Deserializing values with transform parameter" titled "Infer transform from parameter suffix with
get_multiple()
" to document auto transform behaviour.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.