-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api_gateway): new event handler for API Gateway and ALB #418
docs(api_gateway): new event handler for API Gateway and ALB #418
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #418 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 101 101
Lines 3977 3989 +12
Branches 198 197 -1
========================================
+ Hits 3973 3985 +12
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
…tools-python into docs/event-handler-http * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: refactor(event-handler): api gateway handler review changes (#420)
Merging it now @michaelbrewer but I'll wait for your other PR to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will look at adding support for cors=None as the default at the route level.
Issue #, if available:
Description of changes:
Checklist
[x] Create sample infrastructureMinor implementation changes
cc @michaelbrewer
not found
only in message return for security reasonsTuple
type of response to keep it simpler (Dict and Response only)app.get, app.post, app.delete, etc.
to improve DX on IDEs.Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.