Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameter): add dynamodb_endpoint_url for local_testing #376

Merged
merged 6 commits into from
Mar 31, 2021

Conversation

rtrive
Copy link
Contributor

@rtrive rtrive commented Mar 30, 2021

Issue #, if available:

Description of changes:

This feature allows capturing to use this library also with dynamodb running locally with docker

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rtrive rtrive changed the title feat add dynamodb_endpoint_url for local_testing feat: add dynamodb_endpoint_url for local_testing Mar 30, 2021
@michaelbrewer
Copy link
Contributor

@rtrive nice. maybe just add endpoint_url param to the docstring

@rtrive rtrive changed the title feat: add dynamodb_endpoint_url for local_testing feat(parameter): add dynamodb_endpoint_url for local_testing Mar 30, 2021
@heitorlessa heitorlessa added this to the 1.14.0 milestone Mar 31, 2021
@heitorlessa
Copy link
Contributor

Grazie mille @rtrive for taking the time to contribute :) I took liberty to fix some small typos and parameter syntax in the docs, and provide an example URL in the docstring to ease IDEs to show what is the expected value.

I'm merging it as soon as all checks pass - Thank you again!!

@heitorlessa heitorlessa merged commit 1b5d46a into aws-powertools:develop Mar 31, 2021
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Apr 4, 2021
* develop:
  fix(idempotent): Correctly raise IdempotencyKeyError (#378)
  feat(event-handler): Add AppSync handler decorator (#363)
  feat(parameter): add dynamodb_endpoint_url for local_testing (#376)
  fix(parser): S3Model support empty keys (#375)
  fix(data-classes): Add missing operationName (#373)
  fix: perf tests for Logger and fail str msgs
  feat(parser): Add S3 Object Lambda Event (#362)
  build(pre-commit): Add pre-commit to make pr (#368)
  fix(tracer): Correct type hint for MyPy (#365)
  fix(metrics): AttributeError raised by MediaManager and Typing and docs (#357)

Signed-off-by: heitorlessa <[email protected]>
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jul 19, 2022
@github-actions
Copy link
Contributor

This is now released under 1.26.5 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants