fix(tracer): Correct type hint for MyPy #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heitorlessa
approved these changes
Mar 25, 2021
Sorry it had to be a Union and this is MyPy gets pretty confusing :) |
|
No problem at all, I’ve been postponing until this next release because my
first attempt raised many false positives I didn’t have time to investigate.
It goes without saying how much I appreciate the help here.
Feel free to add any additional fix onto that AppSync PR as I’ll review it
tomorrow
…On Thu, 25 Mar 2021 at 19:44, Michael Brewer ***@***.***> wrote:
Thanks a lot @michaelbrewer <https://github.com/michaelbrewer> !!
Sorry it had to be a Union and this is MyPy gets pretty confusing :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#365 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBHLSCCDDNLYC6ZBJ2LTFN77FANCNFSM4ZZ47S3Q>
.
|
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Apr 4, 2021
* develop: fix(idempotent): Correctly raise IdempotencyKeyError (#378) feat(event-handler): Add AppSync handler decorator (#363) feat(parameter): add dynamodb_endpoint_url for local_testing (#376) fix(parser): S3Model support empty keys (#375) fix(data-classes): Add missing operationName (#373) fix: perf tests for Logger and fail str msgs feat(parser): Add S3 Object Lambda Event (#362) build(pre-commit): Add pre-commit to make pr (#368) fix(tracer): Correct type hint for MyPy (#365) fix(metrics): AttributeError raised by MediaManager and Typing and docs (#357) Signed-off-by: heitorlessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#360
Description of changes:
Changes:
lambda_handleras a Union with and withoutkwargspatch_modulesas a Unit of Tuple or ListChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.