-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event-handler): Add AppSync handler decorator #363
feat(event-handler): Add AppSync handler decorator #363
Conversation
@heitorlessa i moved this to the event_handler location. Just have not added a new section in the docs for |
Codecov Report
@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
- Coverage 99.94% 99.94% -0.01%
===========================================
Files 97 98 +1
Lines 3687 3686 -1
Branches 175 173 -2
===========================================
- Hits 3685 3684 -1
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how simple the UX is, and mostly intuitive. I've added some comments on debugging statements, internal naming and conventions, and the move to a core utility (in 2.0 we will cease to call core vs general utility).
Summarizing, as once this is done, we are ready to prep for a new release.
|
Most of this has been done, regarding the documentation I would help to have a complete example for both. Either in the core docs or a referenced article/blog post and repo |
looking :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor change to ease coming back at this code (gotta resolver the resolvers within resolvers :D)
Everything else is good to go!
* develop: fix(idempotent): Correctly raise IdempotencyKeyError (#378) feat(event-handler): Add AppSync handler decorator (#363) feat(parameter): add dynamodb_endpoint_url for local_testing (#376) fix(parser): S3Model support empty keys (#375) fix(data-classes): Add missing operationName (#373) fix: perf tests for Logger and fail str msgs feat(parser): Add S3 Object Lambda Event (#362) build(pre-commit): Add pre-commit to make pr (#368) fix(tracer): Correct type hint for MyPy (#365) fix(metrics): AttributeError raised by MediaManager and Typing and docs (#357) Signed-off-by: heitorlessa <[email protected]>
Issue #, if available:
#356
Description of changes:
Changes:
aws_lambda_powertools/event_handler
aws_lambda_powertools/utilities/data_classes/__init__.py
importscurrent_event
andlambda_context
to AppSyncResolverUX example:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.