-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): import time latency by lazily loading high level modules #301
fix(core): import time latency by lazily loading high level modules #301
Conversation
Signed-off-by: heitorlessa <[email protected]>
@heitorlessa nice, definitely handy for lambdas that just want structured logging or want to toggle tracing only for dev and test and disable on production. |
Signed-off-by: heitorlessa <[email protected]>
Done - @nmoutschen, do you have the bandwidth to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions/remarks before I can approve. We also need to include the proper licensing for the class taken from Terraform (Apache-2.0 license).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #301 +/- ##
===========================================
- Coverage 99.71% 99.65% -0.06%
===========================================
Files 87 90 +3
Lines 3150 3206 +56
Branches 149 150 +1
===========================================
+ Hits 3141 3195 +54
- Misses 5 7 +2
Partials 4 4
Continue to review full report at Codecov.
|
Issue #, if available: #294
Description of changes:
Checklist
aws_xray_sdk
aws_xray_sdk.core
fastjsonschema
Changes table
Notes
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.