feat: support extra parameter in Logger messages #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #253
Description of changes:
This PR adds support for extra parameter when logging messages across all levels. Any key/value added using
extra
parameter will be at the root level of the structured log.Before this PR, all fields added in
extra
parameter are discarded when structuring logs.UX
Add request_id field while logging a message
FAQ
Q: What's the difference between
structure_log
andextra
after this PR?Keys added with
structure_log
will persist across multiple log messages while keys added viaextra
will only be available in a given log message operation.Example - Persisting payment_id not request_id
Note that
payment_id
remains in both log messages whilebooking_id
is only available in the first message.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.