fix(typing): level arg in copy_config_to_registered_loggers #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function called in the method already allows for int|str.
kbakk
requested review from
leandrodamascena
and removed request for
a team
pull-request-size
bot
added
the
size/S
heitorlessa
changed the title
heitorlessa
approved these changes
Sep 21, 2022
|
Thank you so much @kbakk for the swift turnaround 🥰 |
Codecov ReportBase: 99.73% // Head: 99.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1534 +/- ##
========================================
Coverage 99.73% 99.73%
========================================
Files 127 127
Lines 5729 5729
Branches 651 651
========================================
Hits 5714 5714
Misses 8 8
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
And thanks for getting this merged @heitorlessa 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Fixes #1525
Summary
Changes
Allow both int or str for
levelto copy_config_to_registered_loggersUser experience
See linked issue for type error fixed.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.