chore(core): enable wildcard import for core top-level modules #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
the
size/S
rubenfonseca
changed the title
|
Hi @kt-hr thank you so much for your contribution! Out of an abundance of caution, we decided to merge this into our v2 branch for our v2 release, which we are tracking to the end of September. |
rubenfonseca
approved these changes
Sep 15, 2022
rubenfonseca
force-pushed
the
chore/add-init-export
branch
from
507958e to
4fb7057
Compare
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
heitorlessa
changed the title
rubenfonseca
pushed a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1511
Summary
Changes
These PR explicitly exports the top-level modules such as Logger. This doesn't cause any behaviour changes but makes pyright/pylance happy.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.