Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new section "Migrating from other Loggers" #148

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 28, 2020

Issue #, if available: #143

Description of changes:

This creates a new section to address common concerns customers migrating from Python Logging or other libraries to Powertools Logger:

  • Add clarifications on Service parameter
  • Add clarifications on Inheriting Loggers
  • Add clarifications on Overriding Log records
  • Add clarifications on Logging exceptions

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #148 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          705       705           
  Branches        68        68           
=========================================
  Hits           705       705           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d7c86...82e7d67. Read the comment docs.

@heitorlessa heitorlessa added area/logger documentation Improvements or additions to documentation labels Aug 28, 2020
Copy link
Contributor

@michaelbrewer michaelbrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heitorlessa looks good !

@heitorlessa heitorlessa merged commit ac8c16e into aws-powertools:develop Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants