-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_sources): add CloudWatch dashboard custom widget event #1474
feat(event_sources): add CloudWatch dashboard custom widget event #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1474 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 123 124 +1
Lines 5498 5585 +87
Branches 629 634 +5
========================================
+ Hits 5492 5579 +87
Misses 2 2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Looks pretty good! Just left a small comment to improve the docs, let me know what you think :)
Co-authored-by: Ruben Fonseca <[email protected]>
Hello @sthuber90! This is an awesome PR, thanks a lot for taking the time to help improve the project! I think it's missing a field Could you please add this field? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the domain
field.
@leandrodamascena I looked at the link you posted and in the cloudwatch-custom-widgets-samples repo but didn't find any
Can you please provide a link where the |
Hi @sthuber90 - Answering your comments and questions:
There isn't. I've notified the documentation team to include it.
I should've been more explicit in what examples contained the As we've encountered this issue before (missing schema and docs accuracy), I've deployed all of those examples to confirm whether Steps to reproduce: 1 - I chose the "Echo", "Hello World" and "SVG Pie Chart Example" examples here. 2 - As all the examples are cloudformation templates, I just clicked on the link and deployed it to my account. 3 - When the stack was complete I went to Lambda Function and added a print to the event variable inside the handler function. 4 - I used the dashboard created earlier just to generate logs a few times. After that I could see in the Cloudwatch Lambda Log Groups the |
Thank you for the clarification. I will add the field in the next days 👍 |
@leandrodamascena added |
Hi @sthuber90!. I only removed a line in the example code and now it's ok to merge. Thank you again. |
) Co-authored-by: Ruben Fonseca <[email protected]> Co-authored-by: Leandro Damascena <[email protected]>
Issue number: #1461
Summary
Changes
Added event mapping class for custom widget in CloudWatch dashboard
User experience
With the new
CloudWatchDashboardCustomWidgetEvent
data class users have typed access to the event. The event will have custom parameters provided by the user inevent.params["name"]
,event.raw_event["name"]
andevent["name"]
. If the Lambda function is invoked with thedescribe
parameter, the function should return its documentation. Thedescribe
parameter can be provided alone without thewidgetContext
being part of the event or as a custom param by the invoking user.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/data_classes.md