-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): add support for Lambda Function URL #1442
Conversation
@heitorlessa i wasnt able to push the docs update. |
Hi @ran-isenberg.. I'm refactoring all examples and for now you can add this comment after the description line..
like this: 7be425e#diff-aa083264efcaf3125cc0560e9b88cce2c69e4becd8ea39211057634ec3f56bd9R6 |
Thanks a lot @ran-isenberg !! As @leandrodamascena shared, this is the new doc linting to enforce a consistent style, you can ignore for now with that string at the top of the file since we're refactoring all of it (structure, snippets to be way more realistic, run as-is). @leandrodamascena could you please fix that mypy issue by installing |
pushed the docs ;) |
@heitorlessa it failed on the snappy stuff. I updated from develop branch, hopefully it will work now |
Yes it was fixed on #1446, my other PR was impacted and working after the
merge
…On Fri, 12 Aug 2022 at 08:20, Ran Isenberg ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> it failed on the snappy
stuff. I updated from develop branch, hopefully it will work now
—
Reply to this email directly, view it on GitHub
<#1442 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGY3STSYALQBFFT4I3VYXUKFANCNFSM56IX7WWQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## develop #1442 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 121 123 +2
Lines 5479 5496 +17
Branches 627 629 +2
========================================
+ Hits 5473 5490 +17
Misses 2 2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@rubenfonseca assigned it to you as you fixed the quirks of Function URL. @ran-isenberg CI passed. Ruben is back on Monday from holidays and should get this reviewed and merged next week. Thank you again |
Just rebased with master before the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ran-isenberg thank you for this! Just left two small suggestions. Let me know if it makes sense so we can merge.
aws_lambda_powertools/utilities/parser/envelopes/lambda_function_url.py
Outdated
Show resolved
Hide resolved
…on_url.py Co-authored-by: Ruben Fonseca <[email protected]>
Co-authored-by: Ruben Fonseca <[email protected]>
Hi!! Just in case of better understanding of the project I did a double check and everything seems fine to merge. I ran these changes locally and it went fine. |
@heitorlessa waiting for the merge :) |
@rubenfonseca will be merging ;) Thanks a lot everyone!! |
Thanks again Ran! Can't wait to get this out soon :) |
Issue number: #1425
Summary
Changes
added envelope and model for lambda function url as described at #1425
fixed a bug in api gwv2 model where cognitoIdentity wasnt optional.
I was unable to fix the docs for the parser due to a linter bug, will open an issue.
User experience
Can now use an envelope for lambda function url or extend the model.
Is this a breaking change? No.
RFC issue number:
#1425
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.