Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Complete Tracer BaseProvider on subsegment and context manager #1375

Closed
1 of 2 tasks
Tracked by #1009
heitorlessa opened this issue Jul 25, 2022 · 1 comment
Closed
1 of 2 tasks
Tracked by #1009
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

As of now, Tracer Provider isn't fully typed and documented. We need to complete subsegment context manager typing, and any critical typing from X-Ray SDK that's worth bringing for a Tracing Provider.

Since these might change in the future due to OTel support, we should focus on key features only.

Why is this needed?

As of now, autocomplete isn't fully working for escape hatch features. We don't need to provide all types in X-Ray SDK, but main features that we also make use of, like subsegments and context manager.

from aws_lambda_powertools import Logger, Tracer

tracer.provider # should no longer be Any

Which area does this relate to?

Tracer

Solution

No response

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jul 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Feb 13, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant