Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use OIDC and encrypt release secrets #1355

Merged

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1354

Summary

Changes

Please provide a summary of what's being changed

Migrates static scoped credentials to scoped OIDC and uses new GitHub Environment release for encrypted secrets.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

heitorlessa and others added 27 commits July 22, 2022 10:56
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  chore(deps): bump constructs from 10.1.1 to 10.1.52 (aws-powertools#1343)
  chore(deps-dev): bump mypy-boto3-cloudwatch from 1.24.0 to 1.24.35 (aws-powertools#1342)
…owertools-python into chore/skip-dep-workflow

* 'develop' of https://github.com/heitorlessa/aws-lambda-powertools-python:
  fix(ci): remove unsupported env in workflow_call
  fix(ci): unexpected symbol due to double quotes...
  chore(deps): bump constructs from 10.1.1 to 10.1.52 (aws-powertools#1343)
  chore(deps-dev): bump mypy-boto3-cloudwatch from 1.24.0 to 1.24.35 (aws-powertools#1342)
…owertools-python into develop

* 'develop' of https://github.com/heitorlessa/aws-lambda-powertools-python:
  chore(ci): test upstream job skip
  fix(ci): cond doesnt support two expr w/ env
  chore(ci): test env expr
  fix(ci): only event is resolved in cond
  chore(ci): test default env
  fix(ci): remove unsupported env in workflow_call
  fix(ci): unexpected symbol due to double quotes...
  chore(ci): experiment hardening origin
  chore(ci): experiment hardening origin
  chore: debug full event
  chore: print full workflow event depth
  chore: print full event depth
  chore: dummy for PR test
@heitorlessa heitorlessa requested review from a team as code owners July 22, 2022 12:51
@heitorlessa heitorlessa removed the request for review from a team July 22, 2022 12:51
@heitorlessa heitorlessa requested review from rubenfonseca and sthulb and removed request for a team July 22, 2022 12:51
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 22, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2022
@heitorlessa heitorlessa removed the request for review from sthulb July 22, 2022 12:52
@github-actions github-actions bot added the internal Maintenance changes label Jul 22, 2022
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2022
@heitorlessa heitorlessa linked an issue Jul 22, 2022 that may be closed by this pull request
2 tasks
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@heitorlessa heitorlessa merged commit 501420a into aws-powertools:develop Jul 22, 2022
@heitorlessa heitorlessa deleted the chore/encrypt-release-secrets branch July 22, 2022 12:58
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Migrate static keys to github OIDC for SAR pipeline
2 participants