Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(governance): add new maintenance issue template for tech debt and governance #1326

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 20, 2022

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

Introduces a new issue template to better classify all work related to governance, automation, internal, and tech debt. This will allow us to migrate issues in #1009 and on public board. These haven't been converted to issues due to not belonging to existing templates.

Question: Should we keep internal label for these or create a new label?

Pros of keeping internal: Already defined in MAINTAINERS.md, PR and Release drafting automation

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered MAINTAINERS.md

@boring-cyborg boring-cyborg bot added internal Maintenance changes github-templates labels Jul 20, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2022
@heitorlessa heitorlessa changed the title chore(governance): add new maintenance issue template for tech debt chore(governance): add new maintenance issue template for tech debt and internal affairs Jul 20, 2022
@heitorlessa heitorlessa changed the title chore(governance): add new maintenance issue template for tech debt and internal affairs chore(governance): add new maintenance issue template for tech debt and governance Jul 20, 2022
@heitorlessa heitorlessa requested review from am29d and rubenfonseca and removed request for am29d July 20, 2022 09:53
@leandrodamascena
Copy link
Contributor

These changes look good to me.

It will be revisited when e2e finishes because I think new labels will be added. But for now it's nice.

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still like the "internal" label.

@heitorlessa
Copy link
Contributor Author

Thank you both! Merging

@heitorlessa heitorlessa merged commit 77504dc into aws-powertools:develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-templates internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants