fix(ci): fixes typos and small issues on github scripts #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
The variable `issue` was not defined before.
pull-request-size
bot
added
size/M
rubenfonseca
changed the title
heitorlessa
approved these changes
Jul 18, 2022
| @@ -54,7 +54,7 @@ module.exports = async ({github, context, core}) => { | |||
| } | |||
| } finally { | |||
| if (miss == Object.keys(labels).length) { | |||
| return core.notice(`PR ${PR_NUMBER} title '${PR_TITLE}' doesn't follow semantic titles; skipping...`) | |||
There was a problem hiding this comment.
for my own benefit, why not a return?
Comment on lines
+34
to
+37
| } catch (error) { | ||
| core.setFailed(`Unable to create comment on PR number ${PR_NUMBER}.\n\n Error details: ${error}`); | ||
| throw new Error(error); | ||
| } |
| core.info(`Auto-labeling related issue ${issue} for release`) | ||
| return await github.rest.issues.addLabels({ |
There was a problem hiding this comment.
for my own benefit, why not a return?
heitorlessa
added
the
github-actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1009
Summary
Changes
This PR contains a bunch of small improvements to Github scripts:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.